Improve Auto Splitting runtime in livesplit-core
#749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryZe
added
enhancement
The auto splitting runtime that lives directly in `livesplit-core` used to have a channel that communicates with the background thread where the auto splitter is getting executed. This channel was also used for accessing and modifying the settings. However the design for the settings has improved a lot to the point where multiple threads can interact with them entirely lock free. This change removes the channel entirely and instead provides the lock free way of interacting with the settings. Additionally there's a separate change where the auto splitter can now be precompiled and reinstantiated separately. This allows you to restart an auto splitter without also having to recompile it.
CryZe
force-pushed
the
precompile-non-blocking
branch
from
105c148 to
6535a89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto splitting runtime that lives directly in
livesplit-coreused to have a channel that communicates with the background thread where the auto splitter is getting executed. This channel was also used for accessing and modifying the settings. However the design for the settings has improved a lot to the point where multiple threads can interact with them entirely lock free. This change removes the channel entirely and instead provides the lock free way of interacting with the settings.Additionally there's a separate change where the auto splitter can now be precompiled and instantiated separately. This allows you to restart an auto splitter without also having to recompile it.